Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the [MessagePackFormatter] attribute when MessagePack conversion is enabled #705

Closed
aradalvand opened this issue Nov 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@aradalvand
Copy link

aradalvand commented Nov 15, 2024

Describe the feature

MessagePack support was added in #701, now a MessagePack formatter is generated for every value object, which is great. But the formatters have to be manually registered right now since the value object isn't annotated with the [MessagePackFormatter] attribute (analogous to System.Text.Json's [JsonConverter] attribute), which makes it so that the formatters are automatically picked up by the MessagePack serializer.

Please consider simply adding a [MessagePackFormatter(typeof(<FormatterType>))] on top of the generated value objects when MessagePack conversion is enabled, like some of the other converters.

@SteveDunn
Copy link
Owner

Thanks for the feedback! Released in https://github.com/SteveDunn/Vogen/releases/tag/5.0.6-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants