Skip to content

Commit

Permalink
fix: set yuv full range flag to 1 for VP9 with sRGB (shaka-project#1398)
Browse files Browse the repository at this point in the history
If color_space is VPX_COLOR_SPACE_SRGB, the specs says that color_range
should be 1 i.e. yuv_full_range = true. 

However, yuv_full_range was initialized as false and wasn't set in the branch for color_space
is VPX_COLOR_SPACE_SRGB.

Fixes shaka-project#990

---------

Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
  • Loading branch information
cosmin and joeyparrish authored May 11, 2024
1 parent 98b44d0 commit f6f60e5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packager/media/codecs/vp9_parser.cc
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ bool ReadBitDepthAndColorSpace(BitReader* reader,
}
} else {
// Assume 4:4:4 for colorspace SRGB.
yuv_full_range = true;
chroma_subsampling = VPCodecConfigurationRecord::CHROMA_444;
if (codec_config->profile() & 1) {
bool reserved;
Expand Down

0 comments on commit f6f60e5

Please sign in to comment.