Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HENDRICS 7.0's HENzsearch fast algorithm #138

Closed
Gwenloyer opened this issue Mar 3, 2022 · 2 comments · Fixed by #139
Closed

HENDRICS 7.0's HENzsearch fast algorithm #138

Gwenloyer opened this issue Mar 3, 2022 · 2 comments · Fixed by #139
Labels

Comments

@Gwenloyer
Copy link

Describe the bug
Updated yesterday stingray and hendrics to the latest update. and found 2 issues.
When using the fast algorithm from HENzsearch , the program does not select the highest peak , meaining there is a peak that exceed the threshold but it is not the one selected by HENdrics, when plotting the results of the zsearch , the dotted line are aligned with a small peak or even nothing (in the f space, fdot space alignement is not bugged) and the peak is also ignored when listing best candidates .
Also changing the oversample rate used to change the size of the time bin in Hendrics 6.0 , but now it doesn't do that anymore .
Both of hose problems do not exist for normal Zsearch (i.e. without --fast ) which works perfectly fine.

@Gwenloyer Gwenloyer added the bug label Mar 3, 2022
@Gwenloyer
Copy link
Author

--nbin doesn't work either

@matteobachetti
Copy link
Member

Hi @Gwenloyer, thanks for the detailed report! A couple of followup questions:

  1. Highest peak not selected: I will try to understand what is going on there, I haven't noticed the issue if not in cases where the peaks were very small (compatible with noise)
  2. Oversample rate should not change the time bin, just the frequency bins. Could you clarify what you mean by "time bin"?
  3. Same goes for nbin: where are you measuring the number of bins? Please note that, e.g., HENplot does not use the same nbin used during the search.
    Thanks in advance for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants