Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cross_correlation_notebook.ipynb fails #845

Closed
taldcroft opened this issue Sep 9, 2024 · 1 comment · Fixed by #842
Closed

cross_correlation_notebook.ipynb fails #845

taldcroft opened this issue Sep 9, 2024 · 1 comment · Fixed by #842
Labels
bug It's a bug! Unexpected or unwanted behavior. help wanted We need additional help with these issues!

Comments

@taldcroft
Copy link

Description of the Bug

Cell 16 gives AttributeError: 'NoneType' object has no attribute 'counts'

cs = CrossCorrelation()
cs.corr = np.array([660, 1790, 3026, 4019, 5164, 6647, 8105, 7023, 6012, 5162])
time_shift, time_lags, n = cs.cal_timeshift(dt=0.5)

Steps/Code to Replicate the Bug

Run the notebook (MacOS ARM, Python 3.12).

Expected Results

No exception.

Actual Results

Exception.
@taldcroft taldcroft added bug It's a bug! Unexpected or unwanted behavior. help wanted We need additional help with these issues! labels Sep 9, 2024
@matteobachetti
Copy link
Member

Resolved in 8d1c3ff

@matteobachetti matteobachetti mentioned this issue Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug It's a bug! Unexpected or unwanted behavior. help wanted We need additional help with these issues!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Responses to pyOpenSci review StingraySoftware/stingray
2 participants
@taldcroft @matteobachetti