Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Improve performance of 'Compare' Feature #298

Closed
Joly0 opened this issue Aug 6, 2023 · 4 comments · Fixed by #2124
Closed

[Feature request] Improve performance of 'Compare' Feature #298

Joly0 opened this issue Aug 6, 2023 · 4 comments · Fixed by #2124
Assignees
Labels
enhancement New feature or request Front End Issues or pull requests related to front-end development

Comments

@Joly0
Copy link

Joly0 commented Aug 6, 2023

Hey, i am trying to compare 2 100MB pdf's and when i do so, Stirling-PDF becomes unresponsive and my browser takes up a huge amount of my pc's memory.
This is especially weird, as i have it installed in a docker container on my server and it should take up all my memory imo.
But nontheless the memory issues, my browser becomes completly unresponsive and notices me, that Stirling-PDF tab is the reason for that

@Frooodle
Copy link
Member

Frooodle commented Aug 6, 2023

Compare is client side not server as its pure JS
So it would be client side that takes the hit

As for it crashing, the type of text comparison it does it quite heavy so yeah it probably isnt good for extremely large ones
Ill add a warning for this

@Joly0
Copy link
Author

Joly0 commented Aug 6, 2023

Hm, so there is no chance to get this working for larger files?
Had to switch to https://tools.pdf24.org/en/compare-pdf for that task (it seems like it doesnt rely on the client side), but otherwise i love Stirling-PDF and would really like to use that feature aswell :)
But no problem if its not doable. Still great job on this project, highly appreciate your work :D

@Frooodle
Copy link
Member

Frooodle commented Aug 6, 2023

I'll see what i can do :P

@Frooodle Frooodle changed the title Compare is unusable (for large files?) [Feature request] Improve performance of 'Compare' Feature Aug 6, 2023
@Frooodle Frooodle added enhancement New feature or request Front End Issues or pull requests related to front-end development labels Jan 4, 2024
@Frooodle
Copy link
Member

Can implement
https://github.com/kpdecker/jsdiff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Front End Issues or pull requests related to front-end development
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants