-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TableView's Section background color is not set properly per platform #3168
Comments
I guess we didn't fix that in #2987? |
Is this still an issue? |
@drewvolz yes. However! I think I know what's causing it now – React Navigation sets a default background color on the views that it manages, and I think that's causing the slight-but-distinct color shift. I haven't checked this yet, but I think that we can just set |
Was this not closed by #3462? |
Nope… |
gah. thanks. |
With the addition of #5947, this now also impacts iOS. |
I think we can point to AAO-React-Native/modules/tableview/index.tsx Lines 11 to 19 in be76795
In most cases we've assigned this to a platform color AAO-React-Native/modules/colors/platform.js Lines 23 to 24 in 134a85f
and react-native-tableview-simple's default tint color is Do we want to set the tint color to be transparent (removing it) or change it to match the background of our views? What is the best way forward here? |
Sad.
The text was updated successfully, but these errors were encountered: