Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableView's Section background color is not set properly per platform #3168

Open
rye opened this issue Nov 8, 2018 · 10 comments
Open

TableView's Section background color is not set properly per platform #3168

rye opened this issue Nov 8, 2018 · 10 comments
Assignees
Labels
bug/general bug/layout design/HIG human interface guidelines design/MD material design
Milestone

Comments

@rye
Copy link
Member

rye commented Nov 8, 2018

Sad.

@rye rye added this to the v2.6.4 milestone Nov 8, 2018
@drewvolz
Copy link
Member

drewvolz commented Nov 8, 2018

I guess we didn't fix that in #2987?

@hawkrives hawkrives changed the title Weird borders in balances? TableView's Section background color is not set properly for Android Nov 26, 2018
@hawkrives hawkrives self-assigned this Dec 16, 2018
@rye rye modified the milestones: v2.6.4, v2.7.0 Dec 18, 2018
@rye rye modified the milestones: v2.7.0, v2.8.0 Feb 4, 2019
@drewvolz
Copy link
Member

Is this still an issue?

@hawkrives
Copy link
Member

@drewvolz yes.

However! I think I know what's causing it now – React Navigation sets a default background color on the views that it manages, and I think that's causing the slight-but-distinct color shift.

I haven't checked this yet, but I think that we can just set {backgroundColor: transparent} on Section for Android. (I haven't just PR'd it, either, because it could well force them to be black backgrounds. Idk.)

@drewvolz
Copy link
Member

Was this not closed by #3462?

@hawkrives
Copy link
Member

hawkrives commented Jul 16, 2019

Nope…

@rye
Copy link
Member Author

rye commented Sep 7, 2019

This has since been resolved, so I'm closing this issue.

@rye rye closed this as completed Sep 7, 2019
@rye
Copy link
Member Author

rye commented Sep 7, 2019

@rye rye reopened this Sep 7, 2019
@hawkrives
Copy link
Member

gah. thanks.

@drewvolz drewvolz changed the title TableView's Section background color is not set properly for Android TableView's Section background color is not set properly per platform Apr 24, 2022
@drewvolz
Copy link
Member

With the addition of #5947, this now also impacts iOS.

@drewvolz drewvolz mentioned this issue Apr 27, 2022
2 tasks
@drewvolz drewvolz added design/HIG human interface guidelines design/MD material design labels Apr 27, 2022
@drewvolz
Copy link
Member

I think we can point to sectionTintColor just from a cursory search

let Section = (props: SectionInterface): JSX.Element => (
<RNTableView.Section
hideSurroundingSeparators={Platform.OS === 'ios'}
roundedCorners={Platform.OS === 'ios'}
sectionTintColor={sectionBgColor}
withSafeAreaView={false}
{...props}
/>
)

In most cases we've assigned this to a platform color

export const sectionBgColor =
Platform.OS === 'ios' ? iosLightBackground : androidLightBackground

and react-native-tableview-simple's default tint color is #EFEFF4 which is what is showing up around the app.

Do we want to set the tint color to be transparent (removing it) or change it to match the background of our views? What is the best way forward here?

@drewvolz drewvolz mentioned this issue Jun 27, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/general bug/layout design/HIG human interface guidelines design/MD material design
Projects
None yet
Development

No branches or pull requests

3 participants