Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTR clears filters #3351

Closed
hannesmcman opened this issue Dec 24, 2018 · 0 comments
Closed

PTR clears filters #3351

hannesmcman opened this issue Dec 24, 2018 · 0 comments
Labels
bug/general component/filter Related to the Filter view view/menus
Milestone
v2.7.0

Comments

@hannesmcman
Copy link
Member

Problem first stated in #3348 by @drewvolz:

Pull to Refresh when filters are applied -- the button does not change colors nor are the filters listed >on the popup, nor are they applied to the list after PTR-ing. It takes tapping the button again for the >filters to be applied.

Desired behavior: On PTR, filters should not be cleared. I think it is safe to assume that the filter categories will not change after a PTR, so we should be fine just preventing the rebuilding of fresh filters in getDerivedStateFromProps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/general component/filter Related to the Filter view view/menus
Projects
None yet
Milestone
v2.7.0
Development

No branches or pull requests
1 participant
@hannesmcman