Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bit of unique problem) CSM uses three.module.js where as rest of the code uses three.cjs #30

Open
vivasvan1 opened this issue Jan 19, 2023 · 0 comments

Comments

@vivasvan1
Copy link

vivasvan1 commented Jan 19, 2023

Error:

So I was getting this error when i started digging into whats happening:
image

Problem:

three has an _object3DId attached with each Object3d which increments by one like so.

image

So when setting up my world i create few Object3Ds using three.cjs and and the id goes up to some value (example: 13)

Now when CSM constructor (which uses three.module.js)

this.createLights()

is called it create 3 DirectionalLights with id's (example: 8,11,14)

After so the id of next light i make outside CSM will be 14 which exactly aligns with the last DirectionalLight (id: 14) which messes up the UniformCache in three.cjs.

Most cases this will not be a problem as what are the chances of 2 id's to coincide is very rare which wont mess up the cache.

image

Solution:

I dont know yet. If you have an idea do let me know if this is problem of CSM or THREE.js or something in my setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant