Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value comparisons #152

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Fix value comparisons #152

merged 3 commits into from
Dec 10, 2020

Conversation

Stranger6667
Copy link
Owner

Fixes #149

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #152 (fdf47c2) into master (3ab7658) will increase coverage by 0.18%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   71.76%   71.95%   +0.18%     
==========================================
  Files          51       51              
  Lines        3450     3480      +30     
==========================================
+ Hits         2476     2504      +28     
- Misses        974      976       +2     
Impacted Files Coverage Δ
src/lib.rs 18.75% <ø> (ø)
src/keywords/const_.rs 66.07% <50.00%> (ø)
src/keywords/helpers.rs 90.47% <88.23%> (-9.53%) ⬇️
src/keywords/enum_.rs 60.00% <100.00%> (ø)
src/keywords/mod.rs 98.44% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab7658...fdf47c2. Read the comment docs.

@Stranger6667 Stranger6667 merged commit f4a48a4 into master Dec 10, 2020
@Stranger6667 Stranger6667 deleted the dd/fix-value-comparisons branch December 10, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number comparison doesn't work in all cases
1 participant