$ref keyword caches built validators #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to reduce validation penalty performance while interacting with
$ref
s.At the current state every time we're trying to validate such object we're actually re-building all the validators (which is essentially the compile part of the process).
I've tried to move validators build logic (currently in
RefValidator::ensure_validators
) into the compilation process, but it get's though due to potential circular dependencies with references.In order to reduce the code changes and keep performances in consideration I'm opting for storing the validators behind a
RwLock
.The decision of using it is mostly related to the fact that respect a
Mutex
it does have similar performances but at the same time allows multiple readers (in our case multiple parallel validations).Performance improvements are over well 45% improvement for validation. Raw data in here
PS. once again this was spotted while working on maci-split-validators 😎