Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use title attribute from input element #45

Closed
FQ400 opened this issue May 28, 2019 · 0 comments · Fixed by #46
Closed

Use title attribute from input element #45

FQ400 opened this issue May 28, 2019 · 0 comments · Fixed by #46
Labels

Comments

@FQ400
Copy link

FQ400 commented May 28, 2019

Example
https://jsfiddle.net/p0m3aq8o/

Describe the bug
It isn't a bug. It is a feature.
When I add a title to the input I like to transform into a slider I assume to see the title when I hover over the slider.

To Reproduce
Steps to reproduce the behavior:

  1. Open the provided link
  2. Hover over the slider
  3. There is no title "accessability matters"

Expected behavior
When a title attribute is present on an input it should be used as a title on the container-div.

Screenshots
This is my expectation:

Screen Shot 2019-05-28 at 21 16 06

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Firefox
  • Version 67.0

Additional context
I think it could be implemented here:

this.container = document.createElement('div');
dom.addClass(this.container, this.options.fillClass);
directionClass = this.vertical ? this.options.fillClass + '__vertical' : this.options.fillClass + '__horizontal';
dom.addClass(this.container, directionClass);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant