internal/lsp/*_test.go: replace for+success pattern #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
commented
Nov 8, 2024
| select { | ||
| default: | ||
| uri := "file://" + filepath.Join(tempDir, "admins.rego") | ||
|
|
||
| aggs := ls.cache.GetFileAggregates(uri) | ||
| if len(aggs) > 0 { | ||
| success = true | ||
| break // don't sleep |
There was a problem hiding this comment.
that's the only non-automatic change here
anderseknert
approved these changes
Nov 8, 2024
|
I'll fix the linter finding after lunch... |
srenatus
force-pushed
the
sr/success-loop
branch
from
5e70414
to
d506fc7
Compare
It's no functional change, just makes the code a little more concise. Signed-off-by: Stephan Renatus <stephan@styra.com>
srenatus
force-pushed
the
sr/success-loop
branch
from
d506fc7
to
4767411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's no functional change, just makes the code a little more concise.
Hope you don't mind me messing with your test code like this. Originally, I had attempted to use labels, like
outer: for { select { case ... : // stuff break outer }but labels need to be unique within a file, and having to go with
outer1,outer2, ... etc would have been awkward.