Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video and audio not disposing properly #274

Closed
chiefyk opened this issue Apr 28, 2020 · 7 comments · Fixed by #548
Closed

Video and audio not disposing properly #274

chiefyk opened this issue Apr 28, 2020 · 7 comments · Fixed by #548
Labels
bug Something isn't working

Comments

@chiefyk
Copy link

chiefyk commented Apr 28, 2020

When leaving a page with video or audio, the media continues to play. Upon entering the page again, the media will play over the top of the existing media.

I haven't been able to find a way of disposing of the player, unless I have done it wrong.

@KhoiNK
Copy link

KhoiNK commented Jun 1, 2020

I ran into the same problem with you. Did you find any solution for this?
@Sub6Resources I think you forgot to dispose VideoController?

@SaliBhdr
Copy link

@Sub6Resources I have the same problem, any solutions yet?

@ryan-berger
Copy link
Collaborator

@KhoiNK @SaliBhdr This one slipped by me. I'll try to get this into the next release

@ryan-berger ryan-berger added the bug Something isn't working label Jun 16, 2020
@Ceschref
Copy link

Ceschref commented Nov 5, 2020

I have a same issue. My <audio ...> is still running when I close Html Widget. please fix this. It has been in existence since June

@dreamer2q
Copy link

I have noticed this problem, and my solution is to override the default video widget.

customRender: {
              "video": (renderContext, child, attr, _) {
                var videoUrl = attr['src'];
                debugPrint('video: $videoUrl');
                return VideoPlayerWrapper(
                  videoUrl: videoUrl,
                );
            },
}

the VideoPlayerWrapper is a stateful widget, which you should implement dispose() method.

@Ceschref
Copy link

Ceschref commented Nov 5, 2020

great! but I was implement my Widget Audio to custom this, and add [audio, video] to black list. Thank you!

@tneotia
Copy link
Collaborator

tneotia commented Feb 10, 2021

Are you experiencing this issue on Android, iOS, or both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants