Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging in debug mode optional #32

Closed
figengungor opened this issue Oct 24, 2018 · 5 comments
Closed

Make logging in debug mode optional #32

figengungor opened this issue Oct 24, 2018 · 5 comments
Labels
Milestone

Comments

@figengungor
Copy link

Can you please call debugPrint according to an optional parameter like enableLogging and make it false as default?

@Sub6Resources
Copy link
Owner

Yes, we can do that. Sorry for the inconvenience.

@Sub6Resources Sub6Resources added the good first issue Good for newcomers label Oct 24, 2018
@Sub6Resources Sub6Resources added this to the 0.9.0 milestone Oct 24, 2018
@sooxt98
Copy link

sooxt98 commented Oct 27, 2018

the logging is causing a huge lag when rendering a table with large dataset :(

@sjmcdowall
Copy link

Yes can this please sort of be moved and done .. it's driving our team insane having to go throw all those debug messages in the console... (and of course to find OUR own debug messages in the console!) LOL :)

@Sub6Resources
Copy link
Owner

I've opted to just remove debugPrint entirely rather than create an optional parameter. That change has just been published as 0.8.2. If you would like to print each element in the DOM, you can use the customRender callback instead. Thank you all for your patience!

@sjmcdowall
Copy link

So much cleaner! Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants