Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why you guys didnt updae video_player dependency to 2.0.0 #568

Closed
sushilbalami opened this issue Mar 4, 2021 · 6 comments · Fixed by #548
Closed

Why you guys didnt updae video_player dependency to 2.0.0 #568

sushilbalami opened this issue Mar 4, 2021 · 6 comments · Fixed by #548

Comments

@sushilbalami
Copy link

Because app depends on flutter_html ^1.3.0 which depends on video_player ^1.0.1, video_player ^1.0.1 is required.
I have chewie too it needs vide_player 2.0.0
so why flutter _html is not updated and stucked into video_player 1.0.1

@erickok
Copy link
Collaborator

erickok commented Mar 4, 2021

It all depends on the version and dependencies you have. It's not as simple as 'just update to the latest'. We actually don't depend on video_player directly, but via chewie and chewie_audio.

@Pherne
Copy link

Pherne commented Mar 4, 2021

So the only way to solve this currently is to build our own UI/Wrapper for Videos? As far as I could see better_player has a similar problem.

@sushilbalami
Copy link
Author

So the only way to solve this currently is to build our own UI/Wrapper for Videos? As far as I could see better_player has a similar problem.

Recently updated to 2.0 flutter and old version chiewie is not working on app so upgrade to latest.. And now this flutter_html plugin is not working... It needs old chiewie version... 2.0 needs later version flutter_html need old version 😆 what to do

@daohoangson
Copy link

Have you tried using dependency_overrides to use chewie: ^1.0.0?

@erickok
Copy link
Collaborator

erickok commented Mar 4, 2021

We will upgrade too, for sure. And even better, we really want to modularize such that a single dependency cannot break app integrations so easily. But that's a chunk more work.

@tneotia
Copy link
Collaborator

tneotia commented Mar 4, 2021

The new versions of all of these will come with the nullsafety migration. Currently it hasn't been merged a) because it needs a review and more importantly b) chewie_audio is not migrated yet.

Be careful with dependency overrides to forcibly upgrade dependencies as many libraries have breaking changes. However as @daohoangson suggested try downgrading and see if it works out.

@tneotia tneotia mentioned this issue Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants