Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentioning gives incorrect url #73

Closed
Reddiepoint opened this issue Apr 5, 2024 · 2 comments
Closed

Mentioning gives incorrect url #73

Reddiepoint opened this issue Apr 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Reddiepoint
Copy link
Collaborator

Sometimes when I click the mention button it gives the wrong post link: @[url=https://cs.rin.ru/forum/memberlist.php?mode=viewprofile&u=CORRECTID]CORRECT USERNAME[/url], Re: [url=https://cs.rin.ru/forum/viewtopic.php?p=nread#pnread]Post[/url].
I have no idea what causes it. I am using the beta version with change topic to last post and when you go to an unread topic it has a chance of doing that.

@vCybah
Copy link

vCybah commented Apr 6, 2024

Hi, I've seen this https://cs.rin.ru/forum/viewtopic.php?p=nread#pnread link very often when I'm using the copy link button as well, and have to refresh the page or sometimes manually switch to the previous page and then switch back etc.. to get the proper link to copy.

Is it possible it might have something to do with the infinite scrolling? When I'm updating the OP of a thread I'll be scrolling with the infinite loading/scrolling and finding posts to link in the OP, and if I scroll through a "next page load" and click the copy link button on somebody's post, sometimes it will work fine but a lot of times it gives me this link.

Most of the time I've just been going directly to the page the post is on and scrolling down to it (so it doesn't auto load the next page) to copy the link and it works fine then. I'm not sure if this is what's causing it (infinite scrolling) or something else but just wanted to drop this here since it's possibly related. I've had this issue for a while but never thought of reporting it since it's not a very big deal and I assumed it only happens to me since I didn't see any reports etc..

I haven't tested too much what causes it or anything just noticed it a lot over my time using this script.

I just realized I was on an outdated version so I updated to the beta (e7d14eb) but now the buttons in question are just click-able text for me.
Image

They were actually working fine up until today (looking nice, matching the quote/edit buttons) and then I made a post and they went away and changed to this (before updating to the beta). It may just be on my end and if so, my bad, just wanted to bring it up in case it happens to anyone else.
Updating to the beta has the same result, no more buttons, just text. It's just a visual thing as clicking the text still works fine.
Sorry if this is already known/I missed the proper issue for it.

--EDIT--
Looked in the code and realized it's not a bug/issue really that the button images aren't showing up. It's just showing me the alt text because the imgur links weren't loading for some reason. When visiting them in my browser at first they didn't work at all, then disabling my VPN they loaded but removed the i. from the beginning of the links. After turning the VPN back on with a new server it gave me a "Imgur is temporarily over capacity. Please try again later." error. Switching again to another server the links load fine on the imgur site, but when visiting the site as it is in the code with the i.imgur.com instead of imgur.com it's just blank.

When not using the VPN the images load fine on rin, any VPN server I try they don't load on rin, but some I can still load the imgur link to see it so not sure what the deal is since It used to work fine. No big deal either way, as they still function as they should. (aside from the small issue of the pnread link sometimes, sorry for adding the part about the images before I realized that It was just because of my VPN, its loading now on some servers so I guess it just was my VPN not playing nice with imgur)

Thanks for the great script guys!

@Reddiepoint
Copy link
Collaborator Author

I think it has something to do with infinite scrolling. It seems to only affect the top post of a new page when scrolling forward to the next pages.

@Altansar69 Altansar69 added the bug Something isn't working label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants