Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pdf-annotate.js webpack (low priority) #10641

Open
micpap25 opened this issue Jun 28, 2024 · 7 comments · May be fixed by Submitty/pdf-annotate.js#687
Open

Bump pdf-annotate.js webpack (low priority) #10641

micpap25 opened this issue Jun 28, 2024 · 7 comments · May be fixed by Submitty/pdf-annotate.js#687

Comments

@micpap25
Copy link
Contributor

Changes should be made to https://github.com/Submitty/pdf-annotate.js
pdf-annotate.js should be updated to use a webpack version 5. That would require updating many packages and removing the istanbul-instrument-loader package since that is abandoned. This change would increase the security of pdf-annotate.js.

@sxryadipta
Copy link

Could you please elaborate the issue?

Copy link

github-actions bot commented Jul 6, 2024

Hi @sxryadipta,

Thank you for your interest in the Submitty open source project!

We encourage you to join our Zulip server to discuss new features requests, bug reports, and technical implementation questions.

We welcome contributions from new developers! Please read our documentation on how to get started with Submitty, specifically our pages on setting up your development environment and making a pull request.

NOTE: We do not use the Github issue 'assign' feature for first time prospective contributors. You do not need to be assigned to an issue to create a pull request that will be reviewed by our team and then merged if it appropriately resolves the issue.

@thepiyush-303
Copy link

Hi @micpap25
This can be done by running the command:

npm install webpack@latest webpack-cli@latest
and Can you specify which loader you want instead of istanbul-instrument-loader .
Is there a specific implementation you had in mind?
Thankyou

Copy link

github-actions bot commented Jul 6, 2024

Hi @thepiyush-303,

Thank you for your interest in the Submitty open source project!

We encourage you to join our Zulip server to discuss new features requests, bug reports, and technical implementation questions.

We welcome contributions from new developers! Please read our documentation on how to get started with Submitty, specifically our pages on setting up your development environment and making a pull request.

NOTE: We do not use the Github issue 'assign' feature for first time prospective contributors. You do not need to be assigned to an issue to create a pull request that will be reviewed by our team and then merged if it appropriately resolves the issue.

@micpap25
Copy link
Contributor Author

micpap25 commented Jul 8, 2024

@thepiyush-303 no specific implementations in mind; just something that allows us to bump to webpack 5. Feel free to open a PR and we'll take a look at it.

@ARYANSHAH1567
Copy link

Hi, just wanted to know is this issue still open?

Copy link

github-actions bot commented Aug 6, 2024

Hi @ARYANSHAH1567,

Thank you for your interest in the Submitty open source project!

We encourage you to join our Zulip server to discuss new features requests, bug reports, and technical implementation questions.

We welcome contributions from new developers! Please read our documentation on how to get started with Submitty, specifically our pages on setting up your development environment and making a pull request.

NOTE: We do not use the Github issue 'assign' feature for first time prospective contributors. You do not need to be assigned to an issue to create a pull request that will be reviewed by our team and then merged if it appropriately resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants