Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add account operator does not synchronise content #999

Merged
merged 16 commits into from
Sep 30, 2024
Merged

fix: add account operator does not synchronise content #999

merged 16 commits into from
Sep 30, 2024

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Sep 12, 2024 •
edited
Loading

Description

Fixes FL-1697
Fixes FL-1581

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@linear Linear
Copy link

linear bot commented Sep 12, 2024

FL-1697 Changing secrets `secrets-account.yaml` does not trigger the job to add the new organizations to the backend DB

@guilhem-barthes guilhem-barthes changed the title Fix/add account operator does not synchronise content fix: add account operator does not synchronise content Sep 12, 2024
@guilhem-barthes guilhem-barthes force-pushed the fix/add-account-operator-does-not-synchronise-content branch from ac06946 to 2f6128e Compare September 12, 2024 13:26
@guilhem-barthes guilhem-barthes marked this pull request as ready for review September 12, 2024 13:27
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner September 12, 2024 13:27
@linear Linear
Copy link

linear bot commented Sep 13, 2024

FL-1581 Improve django CLI for users and organization management

@guilhem-barthes guilhem-barthes force-pushed the fix/add-account-operator-does-not-synchronise-content branch from 6720c3b to dbc5e9b Compare September 18, 2024 12:23
SdgJlbl
SdgJlbl approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring 🙏

I trust this has been tested on dev?

charts/substra-backend/Chart.yaml Outdated Show resolved Hide resolved
@guilhem-barthes
Copy link
Contributor Author

Thanks for the refactoring 🙏

I trust this has been tested on dev?

Yes it has been (each alpha ^^")

@guilhem-barthes
feat: add sync base for orgs
0d5d71a 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
feat: add sync for incoming organization
7a7af49 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
feat: add sync for outgoing organization
d298e79 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
feat: replace BaseSyncOrganizationCommand by BaseSyncCommand
e7a607e 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
feat: add get in BaseSyncCommand
0984d88 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
chore: remove unused logger
9a53f60 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
chore: remove unused init
70f2278 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
feat: add user sync
455a0b2 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
feat(charts): update job-migrations.yaml to use new commands
327e09d 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
chore: add plural to sync commands to reflect feature
9679d0b 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
doc: change fragment
0b91e5d 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
feat: update base_sync.py to use instance level deletion
06edb61 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
fix: user creation with sync_user didn't work as expected
b5bf79b 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
chore: manually change compute plan user when deleting
2dac969 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
feat: prevent virtual users (external & deleted) to be removed
b10b6df 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
fix: change import to django.conf
8a6cb94 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes force-pushed the fix/add-account-operator-does-not-synchronise-content branch from 4854a8a to 8a6cb94 Compare September 30, 2024 10:00
@guilhem-barthes guilhem-barthes enabled auto-merge (squash) September 30, 2024 10:01
@guilhem-barthes guilhem-barthes merged commit 4ac26da into main Sep 30, 2024
11 checks passed
@guilhem-barthes guilhem-barthes deleted the fix/add-account-operator-does-not-synchronise-content branch September 30, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SdgJlbl SdgJlbl SdgJlbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guilhem-barthes @SdgJlbl