From 1df9c7802d1af9e770acae1e872ff628d4a58306 Mon Sep 17 00:00:00 2001 From: ThibaultFy Date: Fri, 22 Mar 2024 10:31:24 +0100 Subject: [PATCH 1/4] rm type in dataset Signed-off-by: ThibaultFy --- .../examples/substra_core/diabetes_example/run_diabetes.ipynb | 1 - .../examples/substra_core/titanic_example/run_titanic.ipynb | 1 - docs/source/examples/substrafl/get_started/run_mnist_torch.ipynb | 1 - .../examples/substrafl/go_further/run_diabetes_substrafl.ipynb | 1 - docs/source/examples/substrafl/go_further/run_iris_sklearn.ipynb | 1 - docs/source/examples/substrafl/go_further/run_mnist_cyclic.ipynb | 1 - 6 files changed, 6 deletions(-) diff --git a/docs/source/examples/substra_core/diabetes_example/run_diabetes.ipynb b/docs/source/examples/substra_core/diabetes_example/run_diabetes.ipynb index 650d24dc..6a697684 100644 --- a/docs/source/examples/substra_core/diabetes_example/run_diabetes.ipynb +++ b/docs/source/examples/substra_core/diabetes_example/run_diabetes.ipynb @@ -176,7 +176,6 @@ "source": [ "dataset = DatasetSpec(\n", " name=f\"Diabetes dataset\",\n", - " type=\"csv\",\n", " data_opener=assets_directory / \"dataset\" / \"diabetes_opener.py\",\n", " description=data_path / \"description.md\",\n", " permissions=permissions_local,\n", diff --git a/docs/source/examples/substra_core/titanic_example/run_titanic.ipynb b/docs/source/examples/substra_core/titanic_example/run_titanic.ipynb index 94a42276..f97bba4b 100644 --- a/docs/source/examples/substra_core/titanic_example/run_titanic.ipynb +++ b/docs/source/examples/substra_core/titanic_example/run_titanic.ipynb @@ -156,7 +156,6 @@ "source": [ "dataset = DatasetSpec(\n", " name=\"Titanic dataset - Org 1\",\n", - " type=\"csv\",\n", " data_opener=assets_directory / \"dataset\" / \"titanic_opener.py\",\n", " description=assets_directory / \"dataset\" / \"description.md\",\n", " permissions=permissions,\n", diff --git a/docs/source/examples/substrafl/get_started/run_mnist_torch.ipynb b/docs/source/examples/substrafl/get_started/run_mnist_torch.ipynb index 87ba3bd4..e8bfc3da 100644 --- a/docs/source/examples/substrafl/get_started/run_mnist_torch.ipynb +++ b/docs/source/examples/substrafl/get_started/run_mnist_torch.ipynb @@ -184,7 +184,6 @@ "\n", " dataset = DatasetSpec(\n", " name=\"MNIST\",\n", - " type=\"npy\",\n", " data_opener=assets_directory / \"dataset\" / \"mnist_opener.py\",\n", " description=assets_directory / \"dataset\" / \"description.md\",\n", " permissions=permissions_dataset,\n", diff --git a/docs/source/examples/substrafl/go_further/run_diabetes_substrafl.ipynb b/docs/source/examples/substrafl/go_further/run_diabetes_substrafl.ipynb index e795986d..ebea7a45 100644 --- a/docs/source/examples/substrafl/go_further/run_diabetes_substrafl.ipynb +++ b/docs/source/examples/substrafl/go_further/run_diabetes_substrafl.ipynb @@ -158,7 +158,6 @@ "\n", "dataset = DatasetSpec(\n", " name=f\"Diabetes dataset\",\n", - " type=\"csv\",\n", " data_opener=assets_directory / \"dataset\" / \"diabetes_substrafl_opener.py\",\n", " description=data_path / \"description.md\",\n", " permissions=permissions_dataset,\n", diff --git a/docs/source/examples/substrafl/go_further/run_iris_sklearn.ipynb b/docs/source/examples/substrafl/go_further/run_iris_sklearn.ipynb index dc1191ea..f7e1817c 100644 --- a/docs/source/examples/substrafl/go_further/run_iris_sklearn.ipynb +++ b/docs/source/examples/substrafl/go_further/run_iris_sklearn.ipynb @@ -126,7 +126,6 @@ "\n", "dataset = DatasetSpec(\n", " name=\"Iris\",\n", - " type=\"npy\",\n", " data_opener=assets_directory / \"dataset\" / \"iris_opener.py\",\n", " description=assets_directory / \"dataset\" / \"description.md\",\n", " permissions=permissions_dataset,\n", diff --git a/docs/source/examples/substrafl/go_further/run_mnist_cyclic.ipynb b/docs/source/examples/substrafl/go_further/run_mnist_cyclic.ipynb index a6fc288c..234c2d5e 100644 --- a/docs/source/examples/substrafl/go_further/run_mnist_cyclic.ipynb +++ b/docs/source/examples/substrafl/go_further/run_mnist_cyclic.ipynb @@ -189,7 +189,6 @@ "\n", " dataset = DatasetSpec(\n", " name=\"MNIST\",\n", - " type=\"npy\",\n", " data_opener=assets_directory / \"dataset\" / \"cyclic_mnist_opener.py\",\n", " description=assets_directory / \"dataset\" / \"description.md\",\n", " permissions=permissions_dataset,\n", From 381afe4bf92f4c043a7e4b728d4c67179c2f5083 Mon Sep 17 00:00:00 2001 From: ThibaultFy Date: Mon, 25 Mar 2024 17:06:41 +0100 Subject: [PATCH 2/4] chore: changelog Signed-off-by: ThibaultFy --- changes/412.changed | 1 + 1 file changed, 1 insertion(+) create mode 100644 changes/412.changed diff --git a/changes/412.changed b/changes/412.changed new file mode 100644 index 00000000..d4d7bf1c --- /dev/null +++ b/changes/412.changed @@ -0,0 +1 @@ +- Apply changes from breaking PR on Substra (#405(https://github.com/Substra/substra/pull/405)) ([#412](https://github.com/Substra/substra-documentation/pull/412)) From 381377d77d8cc6d95f75540e5df6c0b2e2df22ee Mon Sep 17 00:00:00 2001 From: ThibaultFy Date: Mon, 25 Mar 2024 18:19:34 +0100 Subject: [PATCH 3/4] empty Signed-off-by: ThibaultFy --- changes/412.changed | 1 + 1 file changed, 1 insertion(+) diff --git a/changes/412.changed b/changes/412.changed index d4d7bf1c..3e8b6bd8 100644 --- a/changes/412.changed +++ b/changes/412.changed @@ -1 +1,2 @@ - Apply changes from breaking PR on Substra (#405(https://github.com/Substra/substra/pull/405)) ([#412](https://github.com/Substra/substra-documentation/pull/412)) +empty \ No newline at end of file From 63f03624b20c810816bc4274cc5210222a8e95b4 Mon Sep 17 00:00:00 2001 From: ThibaultFy Date: Mon, 25 Mar 2024 18:19:40 +0100 Subject: [PATCH 4/4] empty Signed-off-by: ThibaultFy --- changes/412.changed | 1 - 1 file changed, 1 deletion(-) diff --git a/changes/412.changed b/changes/412.changed index 3e8b6bd8..d4d7bf1c 100644 --- a/changes/412.changed +++ b/changes/412.changed @@ -1,2 +1 @@ - Apply changes from breaking PR on Substra (#405(https://github.com/Substra/substra/pull/405)) ([#412](https://github.com/Substra/substra-documentation/pull/412)) -empty \ No newline at end of file