Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused assets.py file #403

Merged
merged 1 commit into from
Mar 5, 2024
Merged

chore: remove unused assets.py file #403

merged 1 commit into from
Mar 5, 2024

Conversation

ThibaultFy
Copy link
Member

@ThibaultFy ThibaultFy commented Mar 4, 2024 •
edited
Loading

Related issue

closes FL-608

Summary

Notes

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@ThibaultFy
chore: rm unused file
af52d5b 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@linear Linear
Copy link

linear bot commented Mar 4, 2024

FL-608 Replace metric by function in Substra

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk,substrafl

@Owlfred
Copy link

Owlfred commented Mar 4, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

Booya!

@ThibaultFy ThibaultFy marked this pull request as ready for review March 4, 2024 17:03
@ThibaultFy ThibaultFy requested a review from a team as a code owner March 4, 2024 17:03
SdgJlbl
SdgJlbl approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@ThibaultFy ThibaultFy merged commit 42a5851 into main Mar 5, 2024
6 checks passed
@ThibaultFy ThibaultFy deleted the rm-metric-mentions branch March 5, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SdgJlbl SdgJlbl SdgJlbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThibaultFy @Owlfred @SdgJlbl