Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider rate limiting #29

Open
jburger opened this issue Nov 14, 2020 · 1 comment
Open

Consider rate limiting #29

jburger opened this issue Nov 14, 2020 · 1 comment

Comments

@jburger
Copy link
Contributor

jburger commented Nov 14, 2020

Looks like many of the SL API have rate limiting. https://help.sumologic.com/APIs/Collector-Management-API/Collector-API-Methods-and-Examples#response-fields

While it is early in the project, it might be worth considering baking in support for throttling requests sent by the CLI to assist in rate limit avoidance.
@wizedkyle
Copy link
Contributor

I think that is a good idea looks a simple as looking for a 429 status code then essentially backing off.

If a rate is exceeded, a rate limit exceeded 429 status code is returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jburger @wizedkyle