Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend deployment by docker for Issuance Portal #811

Open
Pratikshakhandagale opened this issue Sep 14, 2023 · 4 comments
Open

Frontend deployment by docker for Issuance Portal #811

Pratikshakhandagale opened this issue Sep 14, 2023 · 4 comments

Comments

@Pratikshakhandagale
Copy link
Member

Pratikshakhandagale commented Sep 14, 2023

Currently, we have to manually deploy the latest code changes to the site. This involves first building the production files and then pushing them to the /var/www/html location.

This feature help us,,

  • When code is merged into the main branch,
  • A Docker image is generated, capturing all the latest changes,
  • Production files are built,
  • The updated site is automatically deployed on the server.
@Pratikshakhandagale Pratikshakhandagale self-assigned this Sep 14, 2023
@srprasanna srprasanna changed the title Frontend deployment by docker Frontend deployment by docker for Issuance Portal Sep 22, 2023
@Sreejit-K
Copy link

@Pratikshakhandagale can you add more details and context here. So that it would help me start workin go on this ticket.

@Pratikshakhandagale
Copy link
Member Author

updated story @Sreejit-K

@Sreejit-K
Copy link

Hi @srprasanna @holashchand

There is a breaking change introduced in docker compose 2.21. Due to which registry CLI needs a few fixes while fetching the status of the containers. More details on the issue are attached here -

docker/compose#10958

docker/compose#10918

Problem:
Registry CLI uses'docker compose ps --format json'system command to fetch the status of the containers and then take actions accordingly. The release notes for 2.21.0 state "Changed docker compose ps and docker compose ps --format=json output to align with Docker CLI."

However, in prior versions, the result was a valid JSON array. 2.21.0 returns individual objects, one after the other, with no [ … ] wrapper. This doesn't seem to be valid JSON.

This is being implemented to execute various commands like registry status, registry down, registry restart and registry init.

Solution:

Found a node library which could replicate the same functionality - https://github.com/apocas/dockerode. I have tested it, its working fine and replicating the same flow . This would make the reigstry CLI compatible with any version of the docker. Wanted your comments before moving ahead with this implementation.

@Sreejit-K
Copy link

Sunbird-RC/sunbird-rc-issuance-ui#24. Workflow using the Github actions of creating and uploading it to ghcr is pending @srprasanna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

No branches or pull requests

5 participants