Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: '<' not supported between instances of 'NoneType' and 'int'. in spafe.features.ngcc.ngcc() #57

Closed
zakaria-kabir opened this issue Feb 18, 2023 · 1 comment · Fixed by #58
Assignees
Labels
bug Something isn't working

Comments

@zakaria-kabir
Copy link

spafe.features.ngcc.ngcc(....., low_freq: [Optional] = None) but doc says, low_freq defalut is 0. Also no where in the function the value has been set.
This occurs error in: (if low_freq argument not passed)

  • gammatone_filter_banks(nfilts, nfft, fs, low_freq, high_freq, scale, order, conversion_approach)
    180
    181 # run checks
    --> 182 if low_freq < 0:
    183 raise ParameterError(ErrorMsgs["low_freq"]) *

image

@zakaria-kabir zakaria-kabir changed the title TypeError: '<' not supported between instances of 'NoneType' and 'int' TypeError: '<' not supported between instances of 'NoneType' and 'int'. in spafe.features.ngcc.ngcc() Feb 18, 2023
@SuperKogito SuperKogito self-assigned this Feb 26, 2023
@SuperKogito SuperKogito added the bug Something isn't working label Feb 26, 2023
@SuperKogito
Copy link
Owner

This is a good catch. I already found the issue and I will be releasing the fix asap.
Thank you for reporting ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants