Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hebrew letters didn't appear [status: awaiting merge] #1492

Closed
ghost opened this issue Aug 3, 2020 · 2 comments
Closed

Hebrew letters didn't appear [status: awaiting merge] #1492

ghost opened this issue Aug 3, 2020 · 2 comments
Labels
category:code type:bug

Comments

@ghost
Copy link

ghost commented Aug 3, 2020 •
edited by ghost
Loading

SuperTux version: v0.6.2
PC information: A 64-bit PC running Windows 10 and Linux.

Expected behavior

The Hebrew and English/Latin characters both are displayed well.

Actual behavior

The Hebrew characters are not displayed in language auto-detect, And the English/Latin characters are not displayed when choosing Hebrew (non auto-detect).

*I found a better Hebrew supporting font than Yehuda and Noto Sans, and it supports English/Latin characters. Link: http://hebrew-font-shuneet.com/font/index.html.

Ideal steps to reproduce actual behavior

  1. Merge the Hebrew font (Shuneet or Yehuda CLM) into SuperTux-Medium.ttf.
  2. Modify resources.cpp.

Alternative steps to reproduce actual behavior
*There is an pending pull request with theese steps. Link: #1520.

  1. Use Shuneet font instead of Yehuda CLM.
  2. Modify resources.cpp if needed.
@serano01 serano01 linked a pull request Aug 10, 2020 that will close this issue
An outdated pull request. The updated pull request is #1520 #1495
Closed
@Zwatotem
Copy link
Member

@omeritzics Does 583adad solve the issue listed?
Note, that some texts in Hebrew are missing due to incomplete translation. We rely on community translating the game to different languages.

@ghost
Copy link
Author

ghost commented Aug 10, 2020 •
edited by ghost
Loading

No, replacing the font Yehuda doesn't fix the issue, it is an additional improvement. The solution is a font with Hebrew and Latin/English character support.

@ghost ghost mentioned this issue Aug 14, 2020
Closed
@ghost ghost changed the title The Hebrew letters didn't appear Hebrew display problem Aug 19, 2020
@ghost ghost changed the title Hebrew display problem Hebrew character display problem Aug 19, 2020
@ghost ghost mentioned this issue Aug 20, 2020
Closed
@ghost ghost changed the title Hebrew character display problem Hebrew character display problem [ci skip] Aug 22, 2020
@ghost ghost changed the title Hebrew character display problem [ci skip] Hebrew character display problem Aug 22, 2020
This was referenced Aug 22, 2020
Closed
Closed
@ghost ghost changed the title Hebrew character display problem Hebrew character display Aug 27, 2020
@ghost ghost changed the title Hebrew character display Hebrew character display problem Aug 27, 2020
@ghost ghost changed the title Hebrew character display problem [Help wanted] [Priority: Medium] Hebrew character display problem Aug 27, 2020
@ghost ghost changed the title [Help wanted] [Priority: Medium] Hebrew character display problem [Priority: Medium] Hebrew character display problem Aug 27, 2020
@ghost ghost changed the title [Priority: Medium] Hebrew character display problem [Help wanted, Priority: Medium] Hebrew character display problem Aug 27, 2020
@ghost ghost changed the title [Help wanted, Priority: Medium] Hebrew character display problem [Help wanted, Priority: Medium] Hebrew letters didn't appear Aug 27, 2020
@ghost ghost changed the title [Help wanted, Priority: Medium] Hebrew letters didn't appear Hebrew letters didn't appear [Help wanted] Aug 27, 2020
@ghost ghost mentioned this issue Aug 27, 2020
Merged
@ghost ghost changed the title Hebrew letters didn't appear [Help wanted] Hebrew letters didn't appear [status: awaiting merge] Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:code type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

An outdated pull request. The updated pull request is #1520
1 participant
@Zwatotem