Fix Debian package erros. Change arch from "amd64" to "all" #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix lintian errors Short description in debian/changelog to hide lintian changelog warnings Use launcher scripts that run java and electron from /usr/bin
AriaMoradi
requested changes
Jan 16, 2022
AriaMoradi
reviewed
Jan 16, 2022
| #!/bin/sh | ||
|
|
||
| if [ ! -f /usr/bin/electron ]; then | ||
| echo "Electron executable was not found! In order to run this launcher, you need Electron installed." |
There was a problem hiding this comment.
maybe mention the actual package name and an instruction to install electron with apt?
There was a problem hiding this comment.
I couldn't find electron in Debian or Ubuntu's repositories. They install it with npm
There was a problem hiding this comment.
It will be like this:
sudo apt install npm
sudo npm install electron -g
There was a problem hiding this comment.
then ship it with the deb package?
There was a problem hiding this comment.
Maybe someone doesn't want to use Electron launcher and download an additional 100MBs
AriaMoradi
requested changes
Jan 17, 2022
scripts/debian-packager.sh
Outdated
| cp "resources/tachidesk-debug-launcher-standalone.sh" "$orig_dir/debian" | ||
| cp "resources/tachidesk-electron-launcher-standalone.sh" "$orig_dir/debian" | ||
| cp "resources/tachidesk.desktop" "$orig_dir/debian" | ||
| cp "../server/src/main/resources/icon/faviconlogo.png" "$orig_dir/debian" |
There was a problem hiding this comment.
cp "../server/src/main/resources/icon/faviconlogo.png" "$orig_dir/debian/tachidesk.png"
scripts/resources/debian/install
Outdated
| Tachidesk.jar => usr/share/java/tachidesk/tachidesk.jar | ||
| debian/faviconlogo.png => usr/share/pixmaps/tachidesk.png |
There was a problem hiding this comment.
debian/tachidesk.png usr/share/pixmaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lintian errors
Short description in debian/changelog to remove lintian changelog warnings
Use launcher scripts that run java and electron from /usr/bin
I test it properly this time and installed the packaged that GitHub has built on a Debian virtual machine:
https://github.com/mahor1221/Tachidesk-Server/releases