no online fetch on backup #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be fine with this solution, but why not extract the db transaction and make it a seperate function? That way we could also remove the runBlocking in the backup code |
|
This would work too, the issue is that the backup http call might timeout before all online fetches finish? |
|
I beleive we want to avoid all network requests when creating a backup, it should be done as fast as it can |
|
Also that would swallow any errors that we may actually want to see in the endpoints |
|
direct transaction is better I guess. |
This reverts commit 09af582.
|
ready |
Syer10
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposed solution for #195
might close #195