Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get default User Agent from WebView #457

Merged
merged 2 commits into from
Dec 4, 2022
Merged

get default User Agent from WebView #457

merged 2 commits into from
Dec 4, 2022

Conversation

AriaMoradi
Copy link
Member

@AriaMoradi AriaMoradi commented Dec 4, 2022

This approach potentially will cause a pause and memory spike on user's computer.

Also, PlayWright has to download a bunch of stuff on first execution, that will probably worsen the first user experience.

@AriaMoradi AriaMoradi changed the title get default agent from WebView get default user agent from WebView Dec 4, 2022
@AriaMoradi AriaMoradi changed the title get default user agent from WebView get default User Agent from WebView Dec 4, 2022
@AriaMoradi AriaMoradi requested a review from Syer10 December 4, 2022 08:58
Copy link
Collaborator

@Syer10 Syer10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to close the browser and then its good to me 👍

Co-authored-by: Mitchell Syer <Mitchellptbo@gmail.com>
@AriaMoradi AriaMoradi merged commit 07314ef into master Dec 4, 2022
@AriaMoradi AriaMoradi deleted the default-ua branch December 4, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants