Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use displayValues for select filters #177

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

Robonau
Copy link
Contributor

@Robonau Robonau commented Jun 22, 2022

this will fix mangadex filters after tachiyomi changed formats
(will only work for server versions after Syer10's patch to server Suwayomi/Suwayomi-Server#347)

@Robonau Robonau changed the title fix mangadex filters use displayValues for select filters Jun 22, 2022
@Syer10
Copy link
Contributor

Syer10 commented Jun 22, 2022

You could check if displayValues is present/null and use whatever values returns if it is. In JUI I show the raw json objects in the values array if displayValues is null

@Robonau
Copy link
Contributor Author

Robonau commented Jun 22, 2022

You could check if displayValues is present/null and use whatever values returns if it is. In JUI I show the raw json objects in the values array if displayValues is null

if it's not an array of strings it will error and crash
making it not crash is allot more work

@AriaMoradi
Copy link
Member

(will only work for server versions after Syer10's patch to server Suwayomi/Tachidesk-Server#347)

Is that not in the latest Server release?

@Robonau
Copy link
Contributor Author

Robonau commented Jun 23, 2022

ye it was already merged so not a problem

@AriaMoradi AriaMoradi merged commit 14a9ffa into Suwayomi:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants