Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make default reader settings changeable #217

Merged
merged 6 commits into from
Jan 6, 2023
Merged

make default reader settings changeable #217

merged 6 commits into from
Jan 6, 2023

Conversation

schroda
Copy link
Collaborator

@schroda schroda commented Jan 1, 2023

Closes #214

@schroda
Copy link
Collaborator Author

schroda commented Jan 1, 2023

@schroda
Copy link
Collaborator Author

schroda commented Jan 2, 2023 •
edited
Loading

rebased onto #216

@schroda schroda mentioned this pull request Jan 2, 2023
Merged
@AriaMoradi
Copy link
Member

AriaMoradi commented Jan 6, 2023 •
edited
Loading

rebase please

@AriaMoradi AriaMoradi changed the title Feature/#214 make default reader settings changeable make default reader settings changeable Jan 6, 2023
schroda added 6 commits January 6, 2023 17:22
[#214] Move "reader settings" util functions into new file
04eaf07
[#214] Extract "options" of "ReaderSettings" to new component
ea19d79
[#214] Add component for changing the default reader settings
599bd76
[#214] Add default "ReaderSettings" to "Settings"
fcb19ad
[#214] Use default "ReaderSettings" stored on the server
b0553fe 
Wait for both "manga" and "defaultSettings" to be loaded.
Otherwise, by the time the "manga" response was received, the "defaultSettings" might be still loading and thus, the local fallback "default" settings will get used as the "default settings"
[#214] Save and update "ReaderSettings" options in case they are missing
a6a6089 
- Manga gets read the first time => save settings in metadata
- Default settings get opened the first time => save settings in global metadata
@schroda
Copy link
Collaborator Author

schroda commented Jan 6, 2023

rebase please

done

@AriaMoradi AriaMoradi merged commit dca968f into Suwayomi:master Jan 6, 2023
@schroda schroda deleted the feature/#214_make_default_reader_settings_changeable branch January 6, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] The default reader settings should be changable
2 participants
@schroda @AriaMoradi