Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom navbar for mobile #51

Merged
merged 6 commits into from
Oct 29, 2021
Merged

Bottom navbar for mobile #51

merged 6 commits into from
Oct 29, 2021

Conversation

ff2400t
Copy link
Contributor

@ff2400t ff2400t commented Oct 27, 2021

Added The Mobile Bottom Navigation bar
localhost_3000_library(Pixel 2 XL) (2)
localhost_3000_library(Pixel 2 XL) (1)

- Also made navbar conditional to render only when its on of the paths in the navbar
- Changed /downloads Path title to Downloads
- Added conditional paddingBottom when on mobile
src/App.tsx Show resolved Hide resolved
@ff2400t
Copy link
Contributor Author

ff2400t commented Oct 28, 2021

Now extracted the Bottom Navigation Bar into a separate component

package.json Outdated Show resolved Hide resolved
src/components/navbar/PermanentSideBar.tsx Show resolved Hide resolved
@AriaMoradi AriaMoradi merged commit 88fb4b6 into Suwayomi:master Oct 29, 2021
@ff2400t ff2400t deleted the bottom-navbar-for-mobile branch October 30, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants