This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Avoid color conversion if possible #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbe
force-pushed
the
feature/colorspace-fix
branch
from
d3fe253 to
7feb848
Compare
djbe
force-pushed
the
feature/colorspace-fix
branch
from
7feb848 to
761358a
Compare
djbe
force-pushed
the
feature/colorspace-fix
branch
from
761358a to
efe1aa9
Compare
AliSoftware
pushed a commit
to SwiftGen/templates
that referenced
this pull request
May 6, 2017
…te color in "Generic Gray" colorspace (#41) Associated with SwiftGen/SwiftGenKit#23
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20.
When we convert a color from any color space to the calibrated RGB color space, we're (potentially) throwing away information. The only reason the conversion is there in the first place, is in case the color is in (for example) grayscale, and thus has no red, green and blue components.
This simply adds a check to avoid conversions if possible.