Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub Light/Dark Image Switcher #1398

Closed
daveverwer opened this issue Nov 25, 2021 Discussed in #1397 · 0 comments · Fixed by #1399
Closed

Support GitHub Light/Dark Image Switcher #1398

daveverwer opened this issue Nov 25, 2021 Discussed in #1397 · 0 comments · Fixed by #1399
Assignees

Comments

@daveverwer
Copy link
Member

Discussed in #1397

Originally posted by Sherlouk November 25, 2021
GitHub have recently announced a new feature which allows for markdown documents (such as the READMEs we render) to support images which change based on light/dark mode.

https://twitter.com/ashtom/status/1463554157932023808

![GitHub-Mark-Light](https://user-images.githubusercontent.com/3369400/139447912-e0f43f33-6d9f-45f8-be46-2df5bbc91289.png#gh-dark-mode-only)![GitHub-Mark-Dark](https://user-images.githubusercontent.com/3369400/139448065-39a229ba-4b06-434b-bc67-616e2ed80c8f.png#gh-light-mode-only)

https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to

I don't know how much work it will be to handle this, or indeed what format we get it back in the HTML from GitHub (it might even support it for free!) but would be good to look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant