This repository has been archived by the owner on Jan 19, 2025. It is now read-only.
attempted to improve command organization #1236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jesus this is going to take a while to review, I was not expecting someone besides me to actually make this. |
metehus
reviewed
Oct 6, 2020
|
Btw, two more things:
|
Definitely not. It's a file used by macOS that stores custom attributes of its containing folder, such as the position of icons etc. |
|
Gosh darn macOS adding hidden files. I'll remove them from the PR, and add .DS_Store to the gitignore |
almeidx
reviewed
Oct 7, 2020
almeidx
suggested changes
Oct 10, 2020
almeidx
reviewed
Oct 30, 2020
|
It's on his fork, he can cancel the PR and create a new one targeting dev and them resolving the conflits. |
|
We probably gonna use your PR as a base for categories on @switchblade-next, anyway, thanks for opening it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganized the commands as best as I could discern, also made sure each command has the correct
categoryproperty. Addresses issue #1189