Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to test for Sylius 1.1 + 1.2 + 1.3 & PHP 7.1 + 7.2 & Symfony 3.4 + 4.1/4.2 #151

Closed
stefandoorn opened this issue Dec 4, 2018 · 3 comments
Labels

Comments

@stefandoorn
Copy link
Contributor

I just started developing a new plugin. In case I would like my plugin to support Sylius v1.1 and the underlying, how am I going to do this in Travis? I could go with v1.3 on the master, and create 'old' CI branches for v1.2 and v1.1, but that feels tedious to me. Also #130 & #104 pop up then. Only supporting ^1.3 feels also 'weird' to me, as the plugin itself should be able to support ^1.1. It's mainly that CI is hard on it..

Thanks!

@stefandoorn stefandoorn changed the title How to test for Sylius 1.1 + 1.2 + 1.3 & PHP 7.1 + 7.2 + Symfony 3.4 & 4.1/4.2 How to test for Sylius 1.1 + 1.2 + 1.3 & PHP 7.1 + 7.2 & Symfony 3.4 + 4.1/4.2 Dec 4, 2018
@Zales0123 Zales0123 added the RFC label Dec 4, 2018
@4c0n
Copy link
Contributor

4c0n commented Jun 2, 2020

Although I am not a big fan of git submodules, so far it works for testing on multiple Sylius versions. I haven't gone through the extent of adding multiple Symfony versions and PHP versions, but that's not the hard part and has been done many times over.

https://github.com/4c0n/SyliusBarcodeSearchPlugin/blob/master/.travis.yml

Another option, at least for public repos, is to use flex to literally install the plugin in a new Sylius standard installation and then somehow run the tests. As this works for public repos only I haven't bothered, because I have to maintain plugins in private repos as well and don't like doing things differently there.

Hopes this helps getting this very old topic of the ground!

@pamil
Copy link
Contributor

pamil commented Jun 3, 2020

Is it possible to add some custom config to that submodule?

@pamil
Copy link
Contributor

pamil commented Jun 3, 2020

Btw. let's move the discussion to #104 to keep it in one place.

@pamil pamil closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants