Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] change username to runtime exception #13322

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

SirDomin
Copy link
Contributor

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

just a spec fix, PhpSpec\Matcher\ThrowMatcher is unable to access $serialized, due to change on AuthenticationException, which unsets this field.
image

@SirDomin SirDomin requested a review from a team as a code owner November 23, 2021 09:22
@SirDomin SirDomin added the Maintenance CI configurations, READMEs, releases, etc. label Nov 23, 2021
@lchrusciel lchrusciel changed the base branch from master to 1.10 November 23, 2021 11:03
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "fix-specs-for-authentication" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel closed this Nov 24, 2021
@lchrusciel lchrusciel reopened this Nov 24, 2021
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Nov 24, 2021
@lchrusciel lchrusciel merged commit 8bc28f0 into Sylius:1.10 Nov 24, 2021
@lchrusciel
Copy link
Member

Thank you, @SirDomin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants