Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize variant autocomplete selector #13611

Merged
merged 15 commits into from
Feb 10, 2022
Merged

Optimize variant autocomplete selector #13611

merged 15 commits into from
Feb 10, 2022

Conversation

rafalswierczek
Copy link

@rafalswierczek rafalswierczek commented Feb 7, 2022 •
edited
Loading

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@rafalswierczek rafalswierczek requested a review from a team as a code owner February 7, 2022 16:22
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Feb 7, 2022
GSadee
GSadee reviewed Feb 8, 2022
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be opened against 1.11 branch

src/Sylius/Bundle/ProductBundle/Doctrine/ORM/ProductVariantRepository.php Outdated Show resolved Hide resolved
@rafalswierczek rafalswierczek changed the base branch from master to 1.11 February 8, 2022 10:59
@rafalswierczek rafalswierczek force-pushed the SYL-1866-Optimize-variant-autocomplete-selector branch from b67f2fa to 83e6be1 Compare February 8, 2022 11:29
@rafalswierczek rafalswierczek changed the title [WIP] Optimize variant autocomplete selector Optimize variant autocomplete selector Feb 8, 2022
Zales0123
Zales0123 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now, even better solution than in other autocomplete routes 👍 Solutions proposed by Victor could be tried as improvements after the merge 🖖

@Zales0123 Zales0123 merged commit fea4b7c into Sylius:1.11 Feb 10, 2022
@Zales0123
Copy link
Member

Thanks, Rafał! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvasiloi vvasiloi vvasiloi left review comments

@GSadee GSadee GSadee left review comments

@AdamKasp AdamKasp AdamKasp approved these changes

@SirDomin SirDomin SirDomin approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rafalswierczek @Zales0123 @GSadee @vvasiloi @SirDomin @AdamKasp