Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Fix undefined labels in taxon autocomplete #13737

Merged
merged 3 commits into from
Mar 10, 2022
Merged

[Admin] Fix undefined labels in taxon autocomplete #13737

merged 3 commits into from
Mar 10, 2022

Conversation

ernestWarwas
Copy link
Contributor

@ernestWarwas ernestWarwas commented Mar 8, 2022 •
edited
Loading

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Before:
image

After:
image

@ernestWarwas ernestWarwas requested a review from a team as a code owner March 8, 2022 08:33
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Mar 8, 2022
@ernestWarwas ernestWarwas added the Bug Confirmed bugs or bugfixes. label Mar 8, 2022
@ernestWarwas ernestWarwas changed the title [WIP][Admin] Fix undefined labels in taxon autocomplete [Admin] Fix undefined labels in taxon autocomplete Mar 9, 2022
@AdamKasp
Copy link
Contributor

AdamKasp commented Mar 9, 2022

it looks fine, but I have no idea if it works :( we need some tests for it :)

@vvasiloi
Copy link
Contributor

vvasiloi commented Mar 9, 2022

Maybe do that in the Core Bundle instead of TaxonomyBundle? 🤔

@ernestWarwas ernestWarwas force-pushed the fix-undefined-label branch from 731459c to 658fd30 Compare March 9, 2022 14:10
@ernestWarwas
[Admin] Undefined labels fixed in Taxon scope in CP
a46c931 
[Admin] Undefined labels fixed in Taxon scope in CP

removed choice name

set fallback locale to first translation

admin taxon ajax test
@ernestWarwas
return taxons even phrase is not specified
602529f
@GSadee GSadee merged commit 295f1e2 into Sylius:1.11 Mar 10, 2022
@GSadee
Copy link
Member

GSadee commented Mar 10, 2022

Thanks, Ernest! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafikooo Rafikooo Rafikooo approved these changes

@Ferror Ferror Ferror approved these changes

@vvasiloi vvasiloi vvasiloi approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ernestWarwas @AdamKasp @vvasiloi @GSadee @Ferror @Rafikooo