Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select attribute values accordion #9878

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

Zales0123
Copy link
Member

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Proof 🎉:
https://youtu.be/E0mczsLuPUs

I'm not a JS master, I don't know is it a proper solution... The only thing I'm certain is it didn't work and now works well 🐃

@Zales0123 Zales0123 added Potential Bug Potential bugs or bugfixes, that needs to be reproduced. Admin AdminBundle related issues and PRs. labels Oct 29, 2018
@Zales0123 Zales0123 requested a review from a team as a code owner October 29, 2018 12:28
@pamil pamil changed the base branch from master to 1.3 October 29, 2018 12:39
@pamil
Copy link
Contributor

pamil commented Oct 29, 2018

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "fix-select-attribute-accordion" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil force-pushed the fix-select-attribute-accordion branch from bc57959 to 3ec5c2b Compare October 29, 2018 12:39
@pamil pamil merged commit 0e9e21f into Sylius:1.3 Oct 29, 2018
@pamil
Copy link
Contributor

pamil commented Oct 29, 2018

Thanks, Mateusz! 🎉

@Zales0123 Zales0123 deleted the fix-select-attribute-accordion branch October 29, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants