Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom listener documentation #58

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

maciekpaprocki
Copy link
Contributor

Q A
Branch? any since the implementation
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets just doc
License MIT

The current doc is a bit outdated.

You need to implement the right interface to tell the system which hook should be run.

Hopefully, that will help someone in the future trying to figure out why their listener is not working.

The current doc is a bit outdated. 

You need to implement the right interface to tell the system which hook should be run.  

Hopefully, that will help someone in the future trying to figure out why their listener is not working.
@maciekpaprocki maciekpaprocki requested a review from a team as a code owner April 29, 2021 12:17
@lchrusciel
Copy link
Member

Hey Maciek! Thanks a lot for your proposal and contribution. Please, take my apology that it took so long to merge it :) But it is finally here and I'm glad to welcome you to our community! :)

@lchrusciel lchrusciel added the Bug Confirmed bugs or bugfixes. label Jul 4, 2022
@lchrusciel lchrusciel merged commit 65e2eae into Sylius:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants