remove Boost

[SymbolixAU]

TODO

• remove boost/algorithm
• remove boost/geometry

[dcooley]

Hi @eddelbuettel , hope you don't mind the ping. I'm getting these CRAN warnings related to boost on my latest submission of googlePolylines. Have you seen these before, and is it worth opening an issue over on your BH page?

Here is just a small snippet

using C++ compiler: 'g++.exe (GCC) 12.2.0'
using C++14
g++  -std=gnu++14 -I"D:/RCompile/recent/R/include" -DNDEBUG -I../inst/include -I'D:/RCompile/CRANpkg/lib/4.4/BH/include' -I'D:/RCompile/CRANpkg/lib/4.4/Rcpp/include'   -I"d:/rtools43/x86_64-w64-mingw32.static.posix/include"     -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign  -c RcppExports.cpp -o RcppExports.o
g++  -std=gnu++14 -I"D:/RCompile/recent/R/include" -DNDEBUG -I../inst/include -I'D:/RCompile/CRANpkg/lib/4.4/BH/include' -I'D:/RCompile/CRANpkg/lib/4.4/Rcpp/include'   -I"d:/rtools43/x86_64-w64-mingw32.static.posix/include"     -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign  -c encode.cpp -o encode.o
g++  -std=gnu++14 -I"D:/RCompile/recent/R/include" -DNDEBUG -I../inst/include -I'D:/RCompile/CRANpkg/lib/4.4/BH/include' -I'D:/RCompile/CRANpkg/lib/4.4/Rcpp/include'   -I"d:/rtools43/x86_64-w64-mingw32.static.posix/include"     -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign  -c googlePolylines.cpp -o googlePolylines.o
g++  -std=gnu++14 -I"D:/RCompile/recent/R/include" -DNDEBUG -I../inst/include -I'D:/RCompile/CRANpkg/lib/4.4/BH/include' -I'D:/RCompile/CRANpkg/lib/4.4/Rcpp/include'   -I"d:/rtools43/x86_64-w64-mingw32.static.posix/include"     -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign  -c wkt.cpp -o wkt.o
In file included from D:/RCompile/CRANpkg/lib/4.4/BH/include/boost/mpl/aux_/na_assert.hpp:23,
                 from D:/RCompile/CRANpkg/lib/4.4/BH/include/boost/mpl/arg.hpp:25,
                 from D:/RCompile/CRANpkg/lib/4.4/BH/include/boost/mpl/placeholders.hpp:24,
                 from D:/RCompile/CRANpkg/lib/4.4/BH/include/boost/iterator/iterator_categories.hpp:16,
                 from D:/RCompile/CRANpkg/lib/4.4/BH/include/boost/iterator/iterator_facade.hpp:13,
                 from D:/RCompile/CRANpkg/lib/4.4/BH/include/boost/range/iterator_range_core.hpp:27,
                 from D:/RCompile/CRANpkg/lib/4.4/BH/include/boost/range/iterator_range.hpp:13,
                 from D:/RCompile/CRANpkg/lib/4.4/BH/include/boost/range/as_literal.hpp:18,
                 from D:/RCompile/CRANpkg/lib/4.4/BH/include/boost/algorithm/string/trim.hpp:19,
                 from D:/RCompile/CRANpkg/lib/4.4/BH/include/boost/algorithm/string.hpp:19,
                 from wkt.cpp:5:
D:/RCompile/CRANpkg/lib/4.4/BH/include/boost/mpl/assert.hpp:194:21: warning: unnecessary parentheses in declaration of 'assert_arg' [-Wparentheses]
  194 | failed ************ (Pred::************
      |                     ^~~~~~~~~~~~~~~~~~~
  195 |       assert_arg( void (*)(Pred), typename assert_arg_pred<Pred>::type )
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  196 |     );
      |     ~                
D:/RCompile/CRANpkg/lib/4.4/BH/include/boost/mpl/assert.hpp:194:21: note: remove parentheses
  194 | failed ************ (Pred::************
      |                     ^~~~~~~~~~~~~~~~~~~
      |                     -
  195 |       assert_arg( void (*)(Pred), typename assert_arg_pred<Pred>::type )
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  196 |     );
      |     ~                
      |     -

[eddelbuettel]

100% organic upstream and nuttin' I can do about it. I recommend local use of -Wno-parentheses

Boost is now on GitHub under https://github.com/boostorg so you could check where the current version is at and possible see if you get it fixed upstream. BH's next update is December as usual.

[dcooley]

ok will do - thanks.

[eddelbuettel]

And to be extra sure: you are seeing compiler warnings. correct? As far as I am never these have NEVER become a CRAN nag on the level of a NOTE or WARNING. CRAN generally knows what is external.

[dcooley]

yes these are compiler warnings and not NOTEs or WARNINGS per CRAN. However, I'm trying to work out why my submission was rejected so just going through all the possibilities / logs.