Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Major Issue #12

Open
proudloyaltier opened this issue Nov 23, 2018 · 0 comments
Open

Security Major Issue #12

proudloyaltier opened this issue Nov 23, 2018 · 0 comments

Comments

@proudloyaltier
Copy link

proudloyaltier commented Nov 23, 2018

How to test

  1. Open Synco and click create story
  2. Open console and type in localStorage.name = "<whatever name>"
  3. Click create, it will now post with the modified name

How to fix

firebase.auth().onAuthStateChanged(function (user) {
  setInterval(function () {
    if (firebase.auth().currentUser) {
      if (localStorage.name !== user.email.replace("@fakeemail.com", "")) {
        signout()
      }
    }
  }, 100)
})

@TelOfLolth and @prealge This is a major security issue, place this code at Line 20 of db.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant