Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniqueness of Batch IDs #77

Open
hgrano opened this issue Jun 12, 2024 · 0 comments
Open

Uniqueness of Batch IDs #77

hgrano opened this issue Jun 12, 2024 · 0 comments

Comments

@hgrano
Copy link
Contributor

hgrano commented Jun 12, 2024

The settlement Batch IDs can be re-used in different settlements. Due to the way contract keys work, the same contract key can be used again as long as the old contract was archived. Hence we can have multiple Batches in the PQS database with the same requestors and ID. Therefore when we run queries for the /settlements endpoint, this could cause issues, as the queries assume uniqueness of the Batch IDs. Perhaps there is a better way to join Batches with Instructions to avoid this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant