Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment to 'overdue' flag on Discrepancies #7

Open
jcf2 opened this issue Mar 7, 2024 · 0 comments
Open

Adjustment to 'overdue' flag on Discrepancies #7

jcf2 opened this issue Mar 7, 2024 · 0 comments

Comments

@jcf2
Copy link

jcf2 commented Mar 7, 2024

Background

There is a column "Overdue" that is intended to flag rows on Discrepancies that are probably not "in process", but legitimately missing. This determination is made based on the surgery_week using logic described in README.md:

- Use 'surgery_week' column.
- For Visit 1: overdue if the surgery week is earlier than today
- For Visit 3: overdue if today is >90 days after the surgery_week date

Issues

A problem with this approach is that because surgery dates are rounded to the nearest week, it's possible to get misleading results. For example, a surgery due later this week will be rounded to this Monday, making a day like Tuesday appear to be an "overdue" day if that is the current date. A solution is to use the week after surgery for comparisons (which also addresses the possibility of "in process" cases to an extent).

A second, mostly just cosmetic, issue is that currently all scans are included equally, although some have indicated=0 and thus are not (as of this moment) expected to exist based on what's been reported on REDCap. It seems preferable to have Overdue values defined only when indicated=1 and a scan is thus expected. That would avoid confusing anyone who doesn't realize what indicated means, or decides to count the number of "overdue" scans.

Requested Changes

  • Change logic in README and code to compare to surgery_week + 7
  • Leave Overdue unset (or set Overdue=NA) when indicated=0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant