Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid cron schedule does not include positional information #1629

Closed
alecthomas opened this issue Jun 3, 2024 · 0 comments
Closed

Invalid cron schedule does not include positional information #1629

alecthomas opened this issue Jun 3, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Jun 3, 2024

I typed in an erroneous cron schedule 0 0 0 0 0 and got:

error: build and deploy failed for module "invoicing": failed to build module "invoicing": failed to extract module schema: value 0 out of allowed day of month range of 1-31

The LSP wasn't able to do anything with this, so as a user I didn't know there was an error until I looked at the FTL output, largely defeating the purpose of the VSCode extension.

Two tasks:

  1. The schema for the cron task has positional information, so it should be surfaced.
  2. In the more general case of errors with no positional information, the VSCode extension should pop up a notification.
@alecthomas alecthomas added the bug Something isn't working label Jun 3, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Jun 3, 2024
@ftl-robot ftl-robot mentioned this issue Jun 3, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jun 3, 2024
@gak gak closed this as completed in 90c41b9 Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants