Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload all config/secrets for a module during its deployment #1906

Open
alecthomas opened this issue Jun 28, 2024 · 2 comments
Open

Preload all config/secrets for a module during its deployment #1906

alecthomas opened this issue Jun 28, 2024 · 2 comments

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Jun 28, 2024

We need to treat all resources, including passwords, as dependencies when deploying the module, and block the deploy until they're all available.

@alecthomas alecthomas added bug Something isn't working next Work that will be be picked up next labels Jun 28, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Jun 28, 2024
@ftl-robot ftl-robot mentioned this issue Jun 28, 2024
@matt2e matt2e added P1 and removed triage Issue needs triaging labels Jul 1, 2024
@alecthomas alecthomas added P0 Work on this now and removed P1 labels Jul 2, 2024
@alecthomas alecthomas self-assigned this Jul 2, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jul 2, 2024
@alecthomas alecthomas added P1 and removed P0 Work on this now labels Jul 2, 2024
@alecthomas alecthomas removed their assignment Jul 2, 2024
@alecthomas alecthomas added the next Work that will be be picked up next label Jul 2, 2024
@alecthomas alecthomas changed the title Figure out and fix missing stdout/stderr from plugins Preload all config/secrets for a module during its deployment Jul 2, 2024
@alecthomas alecthomas removed next Work that will be be picked up next P1 bug Something isn't working labels Jul 3, 2024
@matt2e matt2e self-assigned this Jul 16, 2024
@matt2e
Copy link
Contributor

matt2e commented Jul 16, 2024

From other dupe'd issue:

  • Write up design doc first
  • Want a way to make sure all resources are provisioned & valid before reserving a runner and deploying a module
  • At first it will just be to make sure a module context can be created (no missing configs, secrets, dsns)
  • Later it will be used for provisioning dbs, generating DSNs, migrating

@matt2e
Copy link
Contributor

matt2e commented Jul 17, 2024

Taking myself off this for now. The plan was to work on this with the 1Password / secrets epic, but other things have become higher priority. Putting it back in triage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants