Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel: add attributes to all calls: project_name and is_user_service #2023

Closed
deniseli opened this issue Jul 9, 2024 · 0 comments · Fixed by #2255
Closed

otel: add attributes to all calls: project_name and is_user_service #2023

deniseli opened this issue Jul 9, 2024 · 0 comments · Fixed by #2255
Assignees

Comments

@deniseli
Copy link
Contributor

deniseli commented Jul 9, 2024

project_name: from ftl-project.toml

is_user_service: We have the serviceName set here, which currently will be one of ftl-controller, ftl-runner, or <module name>. Technically, we could use ftl-controller || ftl-runner but it would be good to be a bit more explicit.

  • To do this, add bool flag IsInternal to observability.Config so that Init’s callers can configure whether it’s user code or not.
  • Naming: is_user_service, is_internal, or similar are all fine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants