Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel: check attribute for all calls: trace_id #2024

Closed
deniseli opened this issue Jul 9, 2024 · 1 comment
Closed

otel: check attribute for all calls: trace_id #2024

deniseli opened this issue Jul 9, 2024 · 1 comment
Assignees

Comments

@deniseli
Copy link
Contributor

deniseli commented Jul 9, 2024

If you click on any event here , you'll see a trace_id field under Info > otel. Our friendly customer team needs to use trace_id to trace verb-to-verb calls.

The existing trace_id that gets logged by default is probably the one described here.

Separately, our request headers contain a trace_id that can definitely be used to track verb-to-verb calls.

We do not know if the default trace_id field provided by otel (i.e. what we have now in Datadog) is actually correctly instrumented such that it can be used to trace verb-to-verb calls. We also do not know if otel's trace_id is the same as our request headers' trace_id.

The task here is to:

  1. Find answers to these 2 unknowns.
  2. If the existing trace_id does not enable tracing of verb-to-verb calls, then:
    1. we need to either:
      1. Fix it so that the spans we send to otel correctly cover the full call stack
      2. OR, start logging our request headers' trace_id as a new attribute
    2. Cross reference with otel: chat with our friendly customer team to figure out what they expect to see/work in DataDog that isn't WAI #2022 to make sure the users are seeing the same thing as us. Or if they don't realize it's broken and we do, we should give them a heads up (so they're aware until we've fixed it)
  3. Separately, we should check if any request header data (including trace_id) is persisted by default. We should also take a quick pass over to make sure we aren't exporting any sensitive data (e.g. auth tokens).
@github-actions github-actions bot added the triage Issue needs triaging label Jul 9, 2024
@ftl-robot ftl-robot mentioned this issue Jul 9, 2024
@deniseli deniseli mentioned this issue Jul 9, 2024
15 tasks
@safeer safeer self-assigned this Jul 11, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jul 11, 2024
@safeer
Copy link
Contributor

safeer commented Aug 5, 2024

Fixed in #2144

@safeer safeer closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants