Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-commit happens even if tests fail #2057

Closed
matt2e opened this issue Jul 12, 2024 · 2 comments
Closed

Auto-commit happens even if tests fail #2057

matt2e opened this issue Jul 12, 2024 · 2 comments
Assignees
@wesbillman

Comments

@matt2e
Copy link
Collaborator

matt2e commented Jul 12, 2024

Screenshot 2024-07-12 at 1 24 41 PM
@github-actions github-actions bot added the triage Issue needs triaging label Jul 12, 2024
@ftl-robot ftl-robot mentioned this issue Jul 12, 2024
Open
@wesbillman
Copy link
Member

Maybe we should disable auto commit until we have a solution here?

@wesbillman wesbillman self-assigned this Jul 15, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jul 15, 2024
@wesbillman
Copy link
Member

Screenshot 2024-07-16 at 10 29 25 AM
I enabled this on our main branch. Will try auto merging today to make sure it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesbillman wesbillman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wesbillman @matt2e