Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build structure to not include tags in each file #72

Closed
decentralgabe opened this issue Mar 29, 2022 · 1 comment · Fixed by #70
Closed

Change build structure to not include tags in each file #72

decentralgabe opened this issue Mar 29, 2022 · 1 comment · Fixed by #70
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@decentralgabe
Copy link
Member

The library we're using for secp256k1 keys in JWTs requires a go build tag to access the key type.
This results in //go:build jwx_es256k being added to many files in the codepath of accessing that key type.

We should figure out a way to not need to include this tag in so many packages/files, or consumers of this SDK.

@decentralgabe decentralgabe added enhancement New feature or request help wanted Extra attention is needed labels Mar 29, 2022
@decentralgabe
Copy link
Member Author

Fixed by removing tags and setting a GoLand constraint for all tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant