Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider adding a reject message for PFI to send to Alice #348

Open
jiyoonie9 opened this issue Jul 10, 2024 · 0 comments
Open

consider adding a reject message for PFI to send to Alice #348

jiyoonie9 opened this issue Jul 10, 2024 · 0 comments

Comments

@jiyoonie9
Copy link
Contributor

when PFI needs to close a tbdex exchange before an order goes through, it currently sends a Close message, which has the success field in it, a boolean.

However, in the scenario where PFI sends a Close after sending a Quote, it's unclear what success: false means in this scenario. At this point in the exchange, no "true" exchange of assets has occurred, so it's weird to say an exchange was not successful.

Instead, for all the times when PFI needs to close the exchange before the actual money movements have happened, they should send another message, maybe named Reject, to indicate that no money movement has happened, but PFI is declining to move further in the exchange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant